Monday Board
 

Things to look for:

  • Compare to existing website and make sure things look pretty much the same.
  • Unnecessary ID's/classes in templates, such as "my-3" (from bootstrap) or any custom classes that are no longer needed.
  • Unused ID's/classes in CSS files. Some may no longer be in use but weren't removed from the CSS. (I think I removed all of them but I may have missed some).
  • Duplicate rules - e.g. instance where a rule is also set in a "parent" ruleset. Web browser inspector is helpful here.
  • Unnecessary rules - rules that have no actual impact, like display: block on a div.
  • ID's that should be classes.
  • Any other issues you come across.

 

Workflow:

  1. Build a local playground of drupal10 repo, ARTY repo, and ARTA repo. Use Matter Systems database/files.
  2. Switch ARTA theme to "gt-theme-removal" branch.
  3. Create a new branch named after the template you're working on, e.g. block-3d-box, block-accordion, etc. The branch will be deleted once changers are merged. Assign to yourself on the Monday board and set In Progress
  4. Make your changes in the new branch. When finished, push to GitHub, then on GitHub create a pull request from your branch into gt-theme-removal branch. Make sure the request is to gt-theme-removal, the UI may default to 1.x-alpha. Set Mark as the reviewer.
  5. Set item to ready for review in board, add link to pull request in the appropriate field. If no changes were made (no pull request), simply set it to complete.
  6. Switch back to gt-theme-removal branch, select the next template you want to work on, and go back to step 3.

 

Date
Note Type
Devs